Skip to content

Combat: pin non-swing hits, open-questions note, real-server checklist - #390

Open
Travja wants to merge 1 commit into
devfrom
combat/non-swing-hits-open-questions
Open

Travja wants to merge 1 commit into
devfrom
combat/non-swing-hits-open-questions

Conversation

@Travja

@Travja Travja commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What

Investigation, characterization tests and docs only. No behaviour changes.

  • NonSwingHitsCharacterizationTest (20 tests) pins what VanillaWrapperListener does today for hits with no Codex request that are not weapon swings: splash potions and area effect clouds, wind charges, fireballs, snowballs and eggs, llama spit, shulker bullets, evoker fangs, tridents, and how true damage is (not) represented.
  • doc/COMBAT_OPEN_QUESTIONS.md: per case, current behaviour with file:line, whether it is plausibly wrong, options and a recommendation, and the pinning test. The maintainers decide from it.
  • doc/COMBAT_SERVER_TEST_CHECKLIST.md: manual real-server plan for Codex 1.3.0, Divinity 2.0.0 and Fabled, with items marked by how well the automated tests already cover them.
  • The plan and notes docs link to both, and the notes record the new test-environment gaps.

Characterization tests

No characterization-test expectations changed; tests were only added. CombatCharacterizationTest and every other existing test are untouched.

Findings worth a look

  • With a damage stat on any worn item, a thrown potion, wind charge, snowball or egg is handled as the thrower's attack (15 instead of 6, 1 or 0, critical, vampirism).
  • A bare snowball or egg is cancelled by Divinity (zero total). Paper fires the event for 0 damage, so the push is believed lost. Not testable under MockBukkit, so it is on the server checklist (Q4a).
  • A dispenser fireball is reported as WEAPON_PROJECTILE with no attacker.
  • Divinity has no true damage; _vanilla_generic (no defense attached) is the nearest thing.

How it was checked

The cause and damager per case were read from Paper 1.21.11 (CraftEventFactory) and the vanilla 1.21.11 server bytecode. 1.16.5 was not checked; the checklist asks for it.

Verification: full mvn test exits 0 (336 tests, 2 skipped, the existing trident tests). The new tests were shown to fail when the full-attack line and the zero-damage cancel in production code are broken (both reverted).


Generated by Claude Code

Documentation and tests only; no behaviour changes.

- NonSwingHitsCharacterizationTest pins what VanillaWrapperListener does today
  for hits with no damage request that are not weapon swings: splash potions
  and area effect clouds, wind charges, fireballs, snowballs and eggs, llama
  spit, shulker bullets, evoker fangs, tridents, and how true damage is (not)
  represented. No existing test was touched.
- doc/COMBAT_OPEN_QUESTIONS.md gives, per case, the current behaviour with
  file and line, whether it is plausibly wrong, options and a recommendation.
- doc/COMBAT_SERVER_TEST_CHECKLIST.md is the manual real-server plan for the
  Codex 1.3.0, Divinity 2.0.0 and Fabled release, marking what the automated
  tests already cover.
- The plan and notes link to both.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FaEyTtqZTEVEUC8iNVnMSc
@Travja Travja added the build:patch label Nov 18, 2026 — with Claude

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants